Fixes #33165 - Fix undefined resolver method with katello

[xprazak2]

We include the ResolverExtensions in ::HammerCLIForeman::IdResolver, but HammerCLIKatello::IdResolver actually subclasses it and we get:

defined? HammerCLIKatello::IdResolver #=> true
respond_to?(:create_search_options_without_katello_api) #=> false

So it seems like we do not need to check for katello methods inside foreman resolver.

[ofedoren]

Thanks, @xprazak2! Somehow I missed this case...

Although if we return create_search_options(options, api.resource(:ansible_roles), mode) to be the only option here it will break host update --ansible-roles command if hammer-cli-katello plugin is installed.

A better approach here will be to change the condition, please see inline.

[ofedoren]

The easiest fix that comes to my mind is

if self.class.to_s == 'HammerCLIKatello::IdResolver'
  create_search_options_without_katello_api(options, api.resource(:ansible_roles), mode)
else
...

This should ensure that this method will be used if the current resolver comes from katello plugin. to_s is needed in case if katello plugin is not installed, so we don't crash with undefined constant HammerCLIKatello.

But I agree that this is still error-prone, so we should find a better way to deal with IdResolvers. I can imagine that different plugins will try to redefine a command to use its own resolver which will lead to similar problems...

[xprazak2]

Updated.

[ofedoren]

@xprazak2, LGTM, thanks!