Update Rubocop and fix offenses #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archanaserver
changed the title
archanaserver
force-pushed
the
ruby-3.1
branch
3 times, most recently
from
3821bf3
to
afc8ff2
Compare
ehelms
reviewed
Jun 7, 2023
ofedoren
approved these changes
Jun 9, 2023
Gemfile
Outdated
| group :rubocop do | ||
| gem 'rubocop', '~> 1.28.0' | ||
| gem 'rubocop-performance' | ||
| gem 'rubocop-rails' |
There was a problem hiding this comment.
Do we need rubocop-rails for hammer? :) Hammer and plugins are not dependent on Rails, so there is no need for that.
There was a problem hiding this comment.
@ofedoren it is updated now.
ofedoren
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop update to 1.28.0 and fix offenses.