Fixes #28196 - handle error when empty parameters passed

theforeman · Nov 20, 2019 · 1485f8e · 1485f8e
1 parent 98739de
commit 1485f8e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/hammer_cli_foreman/api/oauth/password_grant.rb b/lib/hammer_cli_foreman/api/oauth/password_grant.rb
@@ -30,11 +30,11 @@ def set_token(input_oidc_token_endpoint, input_oidc_client_id, input_user, input
           @user = input_user
           @password = input_password
           @oidc_client_id = input_oidc_client_id if input_oidc_client_id
-          if @user && @password && @oidc_token_endpoint && @oidc_client_id
+          if @user.to_s.empty? || @password.to_s.empty? || @oidc_token_endpoint.to_s.empty? || @oidc_client_id.to_s.empty?
+            @token = nil
+          else
             @token = HammerCLIForeman::OpenidConnect.new(
               @oidc_token_endpoint, @oidc_client_id).get_token(@user, @password)
-          else
-            @token = nil
           end
         end