Fixes #3598 #4476 - setting locale and timeout of api requests #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 works for my use case (image host creation, using a 3min timeout). Ship it :P |
|
Lets pretend, that this does not need any testing, but I definitely would like to see this option documented in Configuration docs. Otherwise it looks good |
|
The options are documented in the config template. I consider it the best place from both users' and maintenance perspective. I'll add a link to that file from the documentation. |
|
👍 Thanks! |
mbacovsky
added a commit
that referenced
this pull request
Mar 25, 2014
Fixes #3598 #4476 - setting locale and timeout of api requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing this, please make sure you have checked out theforeman/hammer-cli#98