Fixes #5556, #8246, #8299 as they are related

[tstrachota]

Needs to be merged together with theforeman/hammer-cli#151

• adds better error message when searchable options are missing
• resolves params with array of names to ids
• adds more name parameters to host and hostgroup create/update

[tstrachota]

Related test update is here:
theforeman/hammer-tests#6

Check the test run:
http://ci.theforeman.org/job/systest_foreman_hammer_nightly/47/default/

[mbacovsky]

Could ApipieBindings::Inflector.pluralize bring more flexibility?

[mbacovsky]

hammer os update -h does not offer resolution for plurals

[tstrachota]

The OS issue is covered by:
theforeman/foreman#1990

[tstrachota]

@mbacovsky updated

[mbacovsky]

The code looks good, all the three issues were fixed.
Only issue I found is missing --image in host create and --puppetclasses in hostgroup. Is that for any particular reason?

[tstrachota]

@mbacovsky images are not searchable by anything else than ids. Puppet classes are tricky because the api returns hash class_name -> classes instead of array. It should be fixed now.

[mbacovsky]

Interesting, from https://github.com/theforeman/foreman/blob/develop/app/models/image.rb#L16 it seems scoped search for images is defined on name and work for me in hammer:

hammer compute-resource image list --compute-resource-id  1 --search="name~Ce%"                                                                                                           
---|------------|------------------|----------|---------------------------------------------------------
ID | NAME       | OPERATING SYSTEM | USERNAME | UUID                                                    
---|------------|------------------|----------|---------------------------------------------------------
2  | CentOS 7.0 | CentOS 7.0       | root     | /home/VMs/CentOS-7-x86_64-GenericCloud-20140917_02.qcow2
---|------------|------------------|----------|---------------------------------------------------------

However this feature is not available in the UI.

Thanks for the puppetclass, seems we are almost there 🐇

[mbacovsky]

Looks good now, lets merge it (when the tests are green)!

[mbacovsky]

[test]

[domcleal]

Maybe missing a require on "hammer_cli/apipie/option_definition.rb"?

/var/lib/workspace/workspace/test_hammer_cli_foreman_pull_request/ruby/1.8.7/lib/hammer_cli_foreman.rb:134: uninitialized constant HammerCLI::Apipie::OptionDefinition (HammerCLI::ModuleLoadingError)
    from /var/lib/workspace/workspace/test_hammer_cli_foreman_pull_request/ruby/1.8.7/test/unit/test_helper.rb:27:in `require'
    from /var/lib/workspace/workspace/test_hammer_cli_foreman_pull_request/ruby/1.8.7/test/unit/test_helper.rb:27
    from /var/lib/workspace/workspace/test_hammer_cli_foreman_pull_request/ruby/1.8.7/test/unit/fact_test.rb:1:in `require'
    from /var/lib/workspace/workspace/test_hammer_cli_foreman_pull_request/ruby/1.8.7/test/unit/fact_test.rb:1

[mbacovsky]

@domcleal, I've merged the related part, with that the OptionDefinition should be defined.