fixes #11236 - add root_pass option #189
Conversation
|
http://projects.theforeman.org/issues/11236 is the Hammer CLI ticket, this one's for Foreman core only. Should there be an --ask-* flag too? |
|
@shlomizadok, this pull request is currently not mergeable. Please rebase against the master branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running: This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Waiting on contributor
and removed
Needs testing
Needs re-review
Not yet reviewed
labels
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
@domcleal - changed the ticket number (sorry for the confusion) and add --ask-* flag. (thanks for this) |
shlomizadok
changed the title
| end | ||
|
|
||
| def self.ask_password | ||
| prompt = "Enter the root password for the host group: " |
There was a problem hiding this comment.
missing string extraction here
There was a problem hiding this comment.
(And avoid extracting the trailing space, please)
|
Extracted |
| end | ||
|
|
||
| def self.ask_password | ||
| prompt = _("Enter the root password for the host group:") |
There was a problem hiding this comment.
Unless ask adds it for you, you might need to put the space after the extracted string instead, e.g. _("Enter:") + " " so the UI's correctly spaced.
|
Added |
|
Works well, merging. Thanks @shlomizadok |
fixes #11236 - add root_pass option
No description provided.