Fixes #19602 - Disable auth login when sessions are off #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ares
requested changes
Jul 21, 2017
lib/hammer_cli_foreman/auth.rb
Outdated
| @@ -10,6 +10,11 @@ class LoginCommand < HammerCLI::AbstractCommand | |||
| option ["-p", "--password"], "PASSWORD", _("password to access the remote system") | |||
|
|
|||
| def execute | |||
| if !(HammerCLIForeman.foreman_api_connection.authenticator.is_a?(HammerCLIForeman::Api::SessionAuthenticatorWrapper)) | |||
| print_message(_("Can't perform login. Make sure you have sessions enabled.")) | |||
There was a problem hiding this comment.
perhaps "Make sure sessions are enabled in hammer configuration file" to make it more clear
tstrachota
force-pushed
the
auth_only_for_sessions
branch
from
ef7580e
to
4dfa279
Compare
|
@ares updated |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.