Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26019 - display uptime #408

Merged
merged 1 commit into from Feb 12, 2019
Merged

Conversation

ares
Copy link
Member

@ares ares commented Feb 8, 2019

No description provided.

@mbacovsky
Copy link
Member

@ares thanks for the patch!
Please rebase the PR it is not compatible with latest hammer-cli and the tests fail.
Also what is the setup when the uptime is part of the host data? Is it a new feature in core?

@ares
Copy link
Member Author

ares commented Feb 11, 2019

rebased
yes, it needs theforeman/foreman#6458 :-)

@mbacovsky
Copy link
Member

Thanks, looks good now, I'll wait with merging till the core PR is merged.

@tbrisker
Copy link
Member

core has been merged

@mbacovsky
Copy link
Member

@tbrisker thanks for the heads up!

@mbacovsky
Copy link
Member

👍 LGTM now. Thanks @ares!

@mbacovsky mbacovsky merged commit 24d9684 into theforeman:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants