Fixes #28176 - Add http-proxy to hammer #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris1984, sure thing. I've already took a look at the code and code-wise LGTM. Didn't tested though.. Also, just for the sake of consistency, it would be nice to have a test also for update command. |
ofedoren
requested changes
Nov 21, 2019
There was a problem hiding this comment.
@chris1984, addition for the previous comment. I don't see an Info command though the api endpoint exists.
|
@ofedoren sounds good will work on the changes you requested and resubmit. Thanks for the review. |
ofedoren
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
@chris1984, I've tested CRUD via hammer http-proxy command and it worked for me.
Code-wise looks good and I appreciate the tests ❤️
Merging, thanks!
shiramax
pushed a commit
that referenced
this pull request
Nov 25, 2019
(cherry picked from commit 95d6811)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic CRUD operations for http-proxies to Hammer