Update foreman.yml #602
Update foreman.yml #602
Conversation
|
Can one of the admins verify this patch? |
|
Hi @ofedoren, following the issue I had, I created this PR. |
There was a problem hiding this comment.
Thanks, @nofaralfasi, although it's acceptable way as well, I'd rather suggest a bit different, what do you think?
config/foreman.yml
Outdated
| @@ -3,7 +3,7 @@ | |||
| :enable_module: true | |||
|
|
|||
| # Your foreman server address | |||
| :host: 'https://localhost/' | |||
| :host: 'http://127.0.0.1:3000' | |||
There was a problem hiding this comment.
| :host: 'http://127.0.0.1:3000' | |
| :host: 'https://127.0.0.1:443' |
There was a problem hiding this comment.
I'm running localhost (127.0.0.1) with http (which I think most people are), and not https.
I guess that the port number is probably not 3000 like in my case for other users, but it didn't work for me when I omitted it.
So I think you know better than me what is best to decide, I just suggested what works for me :)
There was a problem hiding this comment.
Since this file is not for developers only, but any users, I'd recommend to use https :) AFAIR we force Foreman to run on https in production.
There was a problem hiding this comment.
That's a good point. Thank you for bringing this to my attention.
|
What is the next step here? |
It looks like @ofedoren wants to keep it as is. |
nofaralfasi
force-pushed
the
patch-1
branch
2 times, most recently
from
2925b3d
to
889248f
Compare
…a development environment I'm using vanilla foreman and `:host: 'https://localhost/'` didn't work for me, and caused the error: ``` Could not load the API description from the server: Failed to open TCP connection to localhost:443 (Address family not supported by protocol - socket(2) for "localhost" port 443) - is the server down? - was 'foreman-rake apipie:cache' run on the server when using apipie cache? (typical production settings) Warning: An error occured while loading module hammer_cli_foreman. ```
There was a problem hiding this comment.
Thanks, @nofaralfasi, I'm so sorry for not merging this earlier :/
No worries! Thanks :) |
I'm using vanilla foreman and
:host: 'https://localhost/'didn't work for me,and caused the error: