Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35659 - ForemanGoogle plugin #606

Merged
merged 1 commit into from Oct 31, 2022
Merged

Conversation

stejskalleos
Copy link
Contributor

@ofedoren
Copy link
Member

Thanks, @stejskalleos, but since the main PR is about to remove GCE as a whole, I guess we should remove the whole file here as well.

Also, there are few places to edit as well:

@ofedoren
Copy link
Member

@stejskalleos, https://github.com/ofedoren/hammer-cli-foreman-google has been released, so we can proceed with suggested changes here and merge them right away. The plugin can be used even with 3.4, nothing breaks :)

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stejskalleos, let's get this in.

@ofedoren ofedoren merged commit 39f4b41 into theforeman:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants