New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36349 - Update minitest version #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current testing pipeline doesn't run on Ruby 3 so we don't know about any regressions. IMHO that's something to address.
What I would do in the short term is just a single commit that only updates the minitest dependency. Nothing else. That's a good change that has immediate benefits. Adding the required_ruby_version
part to the gemspec has more implications, like fixing CI to verify Ruby 3 as well. Should also be done, but that's no reason to hold something that is already a good thing.
@@ -7,7 +7,7 @@ gem 'gettext', '>= 3.1.3', '< 4.0.0' | |||
group :test do | |||
gem 'rake', '~> 10.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look at if this can be updated to a current version, but it blows up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I found was #612, but that isn't enough to make it pass.
[test hammer] |
ci config fixes in theforeman/jenkins-jobs#331 |
Well, since this PR is just about updating |
@ofedoren the commit message is updated now, also I've created a Redmine issue: https://projects.theforeman.org/issues/36349#change-167113 |
Thanks, @archanaserver, no other changes are required :) @evgeni, are we good to go from the packaging perspective? |
We don't care for deps in Gemfile for packaging, so go! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all :)
Hmm... I've noticed that we still have even older version in hammer core: https://github.com/theforeman/hammer-cli/blob/master/Gemfile#LL10C26-L10C26. I'll open the PR. UPD: done theforeman/hammer-cli#368. |
Adding Ruby v3.1 support.