Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36349 - Update minitest version #611

Merged
merged 1 commit into from May 9, 2023

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Apr 19, 2023

Adding Ruby v3.1 support.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current testing pipeline doesn't run on Ruby 3 so we don't know about any regressions. IMHO that's something to address.

What I would do in the short term is just a single commit that only updates the minitest dependency. Nothing else. That's a good change that has immediate benefits. Adding the required_ruby_version part to the gemspec has more implications, like fixing CI to verify Ruby 3 as well. Should also be done, but that's no reason to hold something that is already a good thing.

@@ -7,7 +7,7 @@ gem 'gettext', '>= 3.1.3', '< 4.0.0'
group :test do
gem 'rake', '~> 10.1.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look at if this can be updated to a current version, but it blows up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I found was #612, but that isn't enough to make it pass.

@evgeni
Copy link
Member

evgeni commented Apr 26, 2023

[test hammer]

@evgeni
Copy link
Member

evgeni commented Apr 26, 2023

ci config fixes in theforeman/jenkins-jobs#331

@ofedoren
Copy link
Member

Well, since this PR is just about updating minitest version, can be the commit message updated? Also, even though this is a single line, I'd prefer a Redmine issue for that as well. Just in case we would need to track down the work towards Ruby 3+ support.

@archanaserver archanaserver changed the title Add Ruby 3 compatibility Fixes #36349 - update minitest version May 3, 2023
@archanaserver
Copy link
Contributor Author

archanaserver commented May 5, 2023

@ofedoren the commit message is updated now, also I've created a Redmine issue: https://projects.theforeman.org/issues/36349#change-167113
Are there any other changes that need to be made?

@archanaserver archanaserver changed the title Fixes #36349 - update minitest version Fixes #36349 - Update minitest version May 5, 2023
@ofedoren
Copy link
Member

ofedoren commented May 5, 2023

Thanks, @archanaserver, no other changes are required :)

@evgeni, are we good to go from the packaging perspective?

@evgeni
Copy link
Member

evgeni commented May 5, 2023

We don't care for deps in Gemfile for packaging, so go! ;)

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all :)

@ofedoren
Copy link
Member

ofedoren commented May 9, 2023

Hmm... I've noticed that we still have even older version in hammer core: https://github.com/theforeman/hammer-cli/blob/master/Gemfile#LL10C26-L10C26. I'll open the PR.

UPD: done theforeman/hammer-cli#368.

@ofedoren ofedoren merged commit 12359d4 into theforeman:master May 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
6 participants