Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7001 - Prints table headers when no data #146

Merged
merged 2 commits into from
Oct 29, 2014
Merged

Fixes #7001 - Prints table headers when no data #146

merged 2 commits into from
Oct 29, 2014

Conversation

adamruzicka
Copy link
Contributor

Old behavior:
$ hammer --output table repository list --organization org-7 --product product-without-repos
No data.

New behavior:
$ hammer --output table repository list --organization org-7 --product product-without-repos

---|------|---------|--------------|----
ID | NAME | PRODUCT | CONTENT TYPE | URL
---|------|---------|--------------|----

@tstrachota
Copy link
Member

Works fine. Could you please add some test for the behaviour?

@adamruzicka
Copy link
Contributor Author

@tstrachota Added some tests

@tstrachota
Copy link
Member

LGTM, thanks @adamruzicka !

tstrachota pushed a commit that referenced this pull request Oct 29, 2014
Merge pull request #146 from adamruzicka/remove-no-data
0918540 
Fixes #7001 - Prints table headers when no data
@tstrachota tstrachota merged commit 0918540 into theforeman:master Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@adamruzicka @tstrachota @theforeman-bot