Fixes #8607 - remove unnecessary module dependency resolution #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't reviewed the code, but this makes a lot more sense and would appear to fix the bug. |
| word.downcase! | ||
| word | ||
| end | ||
|
|
There was a problem hiding this comment.
Could you please add some tests for this function?
|
I agree it makes more sense. My tests were successful. 👍 when the inline comment is fixed. |
|
I think @komidore64 should check this change as well to make sure 'hammer-cli-sam' is fine with that. |
mbacovsky
force-pushed
the
8607_rubygems_fail
branch
from
2c35a4e
to
4f803e8
Compare
|
this shouldn't cause any problems with |
|
Cool, we're good to merge then @mbacovsky |
|
Thanks for review, @tstrachota and @komidore64 |
mbacovsky
added a commit
that referenced
this pull request
Dec 9, 2014
Fixes #8607 - remove unnecessary module dependency resolution
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module dependency resolution is not necessary and should be ensured by the module. From the previous fix I left ordering of the modules and reimplemented detection of loading disables modules as module deps.