Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #20692 - Add job-invocation rerun command #18

Merged
merged 4 commits into from
Mar 5, 2018

Conversation

adamruzicka
Copy link
Contributor

@adamruzicka adamruzicka commented Oct 19, 2017

  • tests

@adamruzicka adamruzicka changed the title Fixes #20496 - Add job-invocation rerun command Fixes #20492 - Add job-invocation rerun command Oct 19, 2017
@adamruzicka adamruzicka changed the title Fixes #20492 - Add job-invocation rerun command Fixes #20692 - Add job-invocation rerun command Oct 19, 2017
@iNecas
Copy link
Member

iNecas commented Nov 11, 2017

Tests are red

Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well on hammer side. There are conflicts though that need to be resolved + waiting for the API issues to be resolved.

@adamruzicka
Copy link
Contributor Author

Rebased

@adamruzicka
Copy link
Contributor Author

Tests are failing because the API was not described correctly at the time of apidoc data creation

@iNecas
Copy link
Member

iNecas commented Mar 2, 2018

The server part is passing: could you update the apidoc data to get the tests passing?

@adamruzicka
Copy link
Contributor Author

I'm trying to, but for some unknown reason apipie-rails doesn't record examples for me. I recall hitting the same issue when I first opened this PR, but back then I worked around it by downgrading apipie-rails to an older version. I tried oldest and newest rails5-compatible version but none seems to produce the examples.

I'm putting this on hold until I discuss the issue with someone who's familiar with apipie-rails in the office.

@adamruzicka
Copy link
Contributor Author

@iNecas API data updated and the tests are passing

@iNecas
Copy link
Member

iNecas commented Mar 5, 2018

Thanks @adamruzicka

@iNecas iNecas merged commit d022608 into theforeman:master Mar 5, 2018
@adamruzicka adamruzicka deleted the rerun branch March 5, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants