-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #20692 - Add job-invocation rerun command #18
Conversation
adamruzicka
commented
Oct 19, 2017
•
edited
edited
- tests
Tests are red |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works well on hammer side. There are conflicts though that need to be resolved + waiting for the API issues to be resolved.
Rebased |
Tests are failing because the API was not described correctly at the time of apidoc data creation |
The server part is passing: could you update the apidoc data to get the tests passing? |
I'm trying to, but for some unknown reason apipie-rails doesn't record examples for me. I recall hitting the same issue when I first opened this PR, but back then I worked around it by downgrading apipie-rails to an older version. I tried oldest and newest rails5-compatible version but none seems to produce the examples. I'm putting this on hold until I discuss the issue with someone who's familiar with apipie-rails in the office. |
@iNecas API data updated and the tests are passing |
Thanks @adamruzicka |