Add matrix for ruby diff values #324
Conversation
There was a problem hiding this comment.
Thanks for working on the fix.
You're missing the steps to run within the matrix. I'm not sure anyone linked it to you yet, but I always find https://www.jenkins.io/doc/book/pipeline/syntax/ to be useful. https://www.jenkins.io/doc/book/pipeline/syntax/#matrix-stages in this particular case.
Could you also rebase? We prefer to avoid merge commits in our PRs.
@ekohl This was helpful. I fixed the syntax now, but I'm facing issue to look for error. Can you help me with this?
Yes, it's now rebased. |
There was a problem hiding this comment.
I'll admit I also need to look this up. You can run the tests locally. We have test and CI simply executes that. So a simple invocation just testing our theforeman.org directory:
./test theforeman.org
This will run:
cd theforeman.org
jenkins-jobs -l debug test -r yaml
(and then some more)
You can also pass a job name if you do it manully:
jenkins-jobs -l debug test -r yaml smart-proxy-develop-source-release
Now that part actually passes, but if you're changing the yaml files then it's very useful.
The other part is that it runs jenkins-lint.py.
To run that, it first generates all the XML:
jenkins-jobs -l debug test -r yaml --config-xml -o output
Then in output you have all the XML files. You're interested in output/smart-proxy-develop-source-release/config.xml, so:
$ ./jenkins-lint.py --xml theforeman.org/output/smart-proxy-develop-source-release/config.xml
{'error': ['Undefined section "matrix" @ line 21, column 5.', 'Missing required section "stages" @ line 11, column 1.']}
theforeman.org/output/smart-proxy-develop-source-release/config.xml: NOT OK
Failed to validate files:
{'error': ['Undefined section "matrix" @ line 21, column 5.', 'Missing required section "stages" @ line 11, column 1.']}
theforeman.org/output/smart-proxy-develop-source-release/config.xml: NOT OKIf you make sure that passes, I'd expect CI to pass as well.
| run_test(ruby) | ||
| } | ||
| } | ||
| stage('Build and Archive Source') { |
There was a problem hiding this comment.
Having this in every stage in the matrix means we'll generate 3 sources. I'm unsure if only one gets used, but it's a bit redundant. You can keep this stage outside of the matrix.
| stage("Clone repository") { | ||
| steps { | ||
| git url: git_url, branch: git_ref | ||
| matrix { |
There was a problem hiding this comment.
This is in the error output:
2023-03-24T16:20:03.7780551Z {'error': ['Undefined section "matrix" @ line 21, column 5.', 'Missing required section "stages" @ line 11, column 1.']}
I think you need this kind of structure:
- stages
- stage: 'test'
- matrix
- stages
- stage: clone
- stage: Test Ruby
- stage: Build and Archive Source
- stage: 'test'
There was a problem hiding this comment.
@ekohl Thanks for the detailed explaination and sharing those resources, it helped! Also locally it is passing all checks and this is the output i got: theforeman.org/output/smart-proxy-develop-source-release/config.xml: OK
(and now i can see here too, it passing all the checks) :)
| } | ||
| stage("Test Ruby") { | ||
| steps { | ||
| run_test(ruby) |
There was a problem hiding this comment.
It doesn't find this variable and I wonder why. Looking at https://www.jenkins.io/doc/book/pipeline/syntax/#declarative-matrix I think it should be
| run_test(ruby) | |
| run_test(env.ruby) |
Though the docs aren't very clear on it.
For reference:
#317 (comment)