Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 6279 - add skip system checks option #106

Merged
merged 1 commit into from Mar 18, 2015
Merged

Conversation

ares
Copy link
Member

@ares ares commented Mar 9, 2015

No description provided.

@@ -711,7 +711,8 @@ but you want the logs to be readable by specific users.
When you want to make sure that user has some software installed or has the
right version you can write a simple script and put it into checks directory.
All files found there will be ran and if any has non-zero exit code, kafo
wont execute puppet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not native English speaker, but i think a slightly better wording would be:

All files found there will be executed and if any of these exits with an non-zero exit code, kafo won't execute puppet but print an error message Your system does not meet configuration criteria.

@ares
Copy link
Member Author

ares commented Mar 18, 2015

Thanks @mmoll, would you give it another round please?

@mmoll
Copy link
Contributor

mmoll commented Mar 18, 2015

untested, but visually OK 👍

@ares
Copy link
Member Author

ares commented Mar 18, 2015

Thank you, merging.

ares added a commit that referenced this pull request Mar 18, 2015
Fixes 6279 - add skip system checks option
@ares ares merged commit 7e46431 into theforeman:master Mar 18, 2015
@ares ares deleted the fix/6279 branch March 18, 2015 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants