fixes #12166 - prevent over-counting in progress bar #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined types are evaluated twice, causing two RESOURCE lines to be printed and double-counting. A set now tracks whether a resource has already been evaluated and prevents progress being incremented again. Resources such as concat 2.x and recursive file (dir) resources will use eval_generate to add more resources into the catalog during evaluation, which isn't in the initial count. These are now ignored by tracking which resources were initially counted and only incrementing the progress bar when those same resources are seen during the run. Anchor and Kafo's own yaml_to_class resources are now also ignored to improve the accuracy of the overall resource count.
|
big 👏 it's much more accurate now, thanks @domcleal, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined types are evaluated twice, causing two RESOURCE lines to be
printed and double-counting. A set now tracks whether a resource has
already been evaluated and prevents progress being incremented again.
Resources such as concat 2.x and recursive file (dir) resources will
use eval_generate to add more resources into the catalog during
evaluation, which isn't in the initial count. These are now ignored by
tracking which resources were initially counted and only incrementing
the progress bar when those same resources are seen during the run.
Anchor and Kafo's own yaml_to_class resources are now also ignored to
improve the accuracy of the overall resource count.