fixes #19254 - check Puppet version is supported by modules #213
Conversation
lib/kafo/puppet_command.rb
Outdated
| next unless metadata['requirements'] && metadata['requirements'].is_a?(Array) | ||
|
|
||
| metadata['requirements'].select { |req| req['name'] == 'puppet' }.each do |req| | ||
| checks << versioncmp(metadata['name'], req['version_requirement']) |
There was a problem hiding this comment.
Should this block als check if name and version_requirement are present or should it assume the metadata is valid?
There was a problem hiding this comment.
Thanks, I've added a check for version_requirement into the select on the previous line, so this block will only run if both are set.
Using the Puppet version requirements from metadata.json in the available modules, the running Puppet version is validated to ensure it is compatible. The user can skip this with `--skip-puppet-version-check` if they wish.
domcleal
force-pushed
the
19254-puppet-version-check
branch
from
36c3e57
to
5f438a7
Compare
|
The PR looks good and works fine. This causes problems with foreman-installer running on puppet 3.8.6 and puppet-extlib 1.1.0 which requires 3.8.7+. I know there's a big group of users with this combination so I want to first make sure there's some better solution than asking them to run the installer with |
|
Thanks, I wasn't aware of that incompatibility. Foreman installer 1.16.x will not support Puppet 3 at all, so it shouldn't matter that much - it would only be a problem with the modules shipped in 1.15 or older. If something similar happened in the future, we would now be a little more aware of it through testing and could either correct the module metadata, or ship a version of the module that does claim to be compatible. Otherwise yes, a user would have to run with the skip argument, but I wouldn't expect that to be the norm. Edit: no problem if you wish to release what's currently on master, and leave this unmerged. |
|
Makes sense, I wanted to do a fix release compatible with 1.15 I think the best will be to bump the version to 2.1.0 once this is merged so if someone will require more fixes to be used with 1.15 we can always continue with 2.0 branch. |
|
Thanks @domcleal, merging. |
Using the Puppet version requirements from metadata.json in the
available modules, the running Puppet version is validated to ensure it
is compatible. The user can skip this with
--skip-puppet-version-checkif they wish.