Fixes #20473 - Error messages are sent to STDERR #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This affected tests, could you please update them? Otherwise 👍 |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Fixed tests, this capturing would be perhaps more appropriate for all tests, but I am not gonna do this in this PR. |
|
APJ |
|
What? ;-) Tests are passing. |
|
Ack Pending Jenkins :-) Thanks @lzap, merging. Let me know if you want a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages are belong to STDERR in UNIX.