Fix #4343 - adds compatibility with latest puppet version #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with major releases from 2.7 to 3.4
| values[:production][:confdir] ||= '/' # just some stubbing | ||
| Puppet.settings[:confdir] ||= '/' # just some stubbing | ||
| if Puppet::Node::Environment.respond_to?(:create) | ||
| env = Puppet::Node::Environment.create(:production, [], '') |
There was a problem hiding this comment.
Why use .create here instead of .new?
There was a problem hiding this comment.
create seems to be preffered method in environment factory but is present only in master (3.5+), I wanted to use the way they use
|
👍 thanks for the quick fix :) |
ares
added a commit
that referenced
this pull request
Feb 14, 2014
Fix #4343 - adds compatibility with latest puppet version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with major releases from 2.7 to 3.4