fixes #14932 - set default strings parser encoding to UTF-8 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,7 @@ def initialize(file) | |||
| raise KafoParsers::ParseError, "'#{command}' returned error\n#{@raw_json}" | |||
| end | |||
|
|
|||
| Encoding.default_external = Encoding::UTF_8 if defined?(Encoding) && Encoding.respond_to?(:default_external=) | |||
There was a problem hiding this comment.
on what Ruby version default_external= is not defined? is that defensive check?
There was a problem hiding this comment.
Yeah, overly defensive - I left it in by accident in c04662f when fixing it for 1.8.7, let me remove it from both places.
domcleal
force-pushed
the
14932-strings-encoding
branch
from
305f875
to
f39525e
Compare
|
Thanks @domcleal, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect tests may fail until #19's merged, as I changed the Jenkins job.