Refs #30365: Ignore symlinks for puppet executable

[ehelms]

No description provided.

[ekohl]

Hmmm, tests are not happy

[ehelms]

Took some finagling, @ekohl do check the test updates for the structural changes

[ehelms]

@ekohl this needs a corresponding look

[ekohl]

This removes the caching of @puppet_bin and I'd prefer to keep that. Any particular reason you're removing it?

[ehelms]

IIRC when I was building the fix, this is cached at a class level which made it hard to test given in tests the paths needed to change to test different combinations. The call to find the bin file did not look expensive so I chose testing over performance gains from caching.

[ekohl]

You can split the logic into two methods: find_puppet_bin and puppet_bin where the latter only performs the caching.

[ehelms]

@ekohl Logic is now split

[ekohl]

Thanks!