Escape commas, slightly differently

[jaredjennings]

This is a slightly different way from #38 to deal with escaped commas in Active Directory DNs, with tests added.

[domcleal]

Thanks, looks fine to me. The only trouble is going to be the negative lookbehind, which isn't Ruby 1.8.7 compatible.

I see no reason for us to keep 1.8.7 compatibility in this gem any more, so let me sort that out first and then we'll be able to take this fix.

[domcleal]

I've removed 1.8.7 from the test matrix in #47, so if you rebase you should pick this up and the tests should go green. Could you also please squash your commits to a single commit?

[jaredjennings]

There remains one possibly important difference between this and #38: @brgerig, having split on a suitably unescaped comma, went on to unescape the commas in the base DN, and I have only unescaped the first attribute. I don't know yet which is the right way to do it.

[domcleal]

I think not escaping it may be more correct. The escapes in the remainder of the DN are probably still valid as the base DN is still a DN, so needs appropriate escaping. The comma escapes when constructing a filter are the ones that are important to remove, since they'd no longer be needed in a filter expression.

[jaredjennings]

OK, it looks like base should remain as it is, with commas escaped. I made an OU with a comma in the name, and a user and a group inside it; put the user in the group; specified the OU as the base_dn (for finding users) and as the group_dn, using a backslashed comma in each; and successfully found the user to be a member of the group, using Active Directory.

[domcleal]

Great, thanks for the patch and re-testing!

[jaredjennings]

See also https://bugzilla.redhat.com/show_bug.cgi?id=1252089