Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit body line length restrictions #127

Merged
merged 1 commit into from Mar 4, 2019

Conversation

johnpmitsch
Copy link

This comes from a community discussion around prprocesssor
line length restrictions.
https://community.theforeman.org/t/loosen-up-the-commit-line-length-restrictions/12934

It was suggested to keep the commit title length restriction the same and
remove the commit body restrictions

This comes from a community discussion around prprocesssor
line length restrictions.
    https://community.theforeman.org/t/loosen-up-the-commit-line-length-restrictions/12934

It was suggested to keep the commit title length restriction the same and
remove the commit body restrictions
Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@johnpmitsch
Copy link
Author

I don't have permissions so someone else will have to merge 🙈

@mmoll
Copy link

mmoll commented Mar 1, 2019

I think there's still no automatic deploy on merge, so leaving this to the ones empowered. 💣

@ekohl ekohl merged commit ea15ddf into theforeman:master Mar 4, 2019
@ekohl
Copy link
Member

ekohl commented Mar 4, 2019

You're correct that there's no auto deploy. For documentation purposes:

[ekohl@redmine01 ~]$ sudo /root/update-prprocessor
[sudo] password for ekohl: 
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 4 (delta 2), reused 3 (delta 2), pack-reused 0
Unpacking objects: 100% (4/4), done.
From https://github.com/theforeman/prprocessor
   1b0e020..ea15ddf  master     -> origin/master
Updating 1b0e020..ea15ddf
Fast-forward
 github/pull_request.rb | 6 ------
 1 file changed, 6 deletions(-)
Using rake 12.2.1
Using addressable 2.3.8
Using multipart-post 2.0.0
Using faraday 0.9.2
Using jgrep 1.5.0
Using json 1.8.6
Using mime-types 2.99.3
Using minitest 5.11.3
Using netrc 0.11.0
Using sawyer 0.6.0
Using octokit 3.8.0
Using rack 1.6.11
Using rack-protection 1.5.5
Using rest-client 1.7.3
Using retriable 1.4.1
Using sentry-raven 2.7.4
Using tilt 2.0.8
Using sinatra 1.4.8
Using bundler 1.7.8
Your bundle is complete!
Use `bundle show [gemname]` to see where a bundled gem is installed.
Updated prprocessor
[ekohl@redmine01 ~]$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants