Set fixed in when a PR is merged #131
Conversation
|
@tbrisker can you have a look at the general workflow in the last commit? I do intend to parse |
|
Looks reasonable to me. I'd be fine with setting the version for cherry-picks manually, since they require special consideration anyways. different projects handle them differently - some do a big cherry-pick PR prior to a new z-stream, some do multiple smaller PRs during the -stable lifetime and some push directly to the stable branch. This would already save the manual work of having to set fixed-in for the large majority of PRs. |
ekohl
force-pushed
the
set-fixed-in
branch
2 times, most recently
from
7d58e97
to
c4a65af
Compare
This refactors functions to use clean types. To validate this, type hints are added. This makes the redmine module a much more pure library that doesn't deal with the output formatting.
Some Redmine projects contain multiple projects and prefix their versions as foreman_plugin-1.2.3 and smart_proxy_plugin-2.3.4. This adds the redmine_version_prefix in the config which allows doing so. It also only considers versions that start with a number because that allows sorting. It will also skip versions such as 'Backlog'.
|
It's hard because a lot depends on setup. To run an instance, need to create a GH app, deploy it an instance and set all the secrets up. I have one at https://github.com/ekohl/gh-test-env and verified it with one issue. I'll need to check again on a project where we combine multiple git repositories though and verify it ends up in the correct versions. |
Replacement of #106. Still untested and needs code to authenticate against Redmine.