add link-to-redmine feature #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
link_to_redmine
branch
from
71c4399
to
6f3816b
Compare
|
this is totally untested, but I think it should do what we wanted? |
ekohl
reviewed
Oct 6, 2023
evgeni
commented
Oct 6, 2023
| @@ -293,7 +304,7 @@ async def run_pull_request_check(pull_request: Mapping, check_run=None) -> bool: | |||
| }, | |||
| ) | |||
|
|
|||
| return conclusion == 'success' | |||
| return (conclusion == 'success', issue_results, invalid_commits) | |||
There was a problem hiding this comment.
no consumer uses invalid_commits, so we could also drop it from the return, but I thought maybe it's useful at some point later
Did you get a chance to test this? |
|
I was the only one complaining this is missing and I got used to using the "checks" tab, so closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.