Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #29220: Disable CRL generation by default #145

Merged
merged 1 commit into from Feb 28, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Feb 28, 2020

No description provided.

Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. If I may ask, why this config change?

@ehelms
Copy link
Member Author

ehelms commented Feb 28, 2020

We do not make use of the Candlepin CRL. As I understand it, this will effectively prevent this task from running and save resources by not calculating the CRL. For installs with many hosts and lots of turnover this can take quite a bit of resources and time to calculate.

@ehelms ehelms merged commit 504ed85 into theforeman:master Feb 28, 2020
@wbclark
Copy link
Contributor

wbclark commented Feb 28, 2020

We do not make use of the Candlepin CRL. As I understand it, this will effectively prevent this task from running and save resources by not calculating the CRL. For installs with many hosts and lots of turnover this can take quite a bit of resources and time to calculate.

Great, makes sense. Thank you for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants