Fixes #29194 - Support EL8 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently failing on I verified that the we are getting the el8 repository on the test VM: Assuming the package is built but not yet available in that repository, I'll next try to manually install it to move forward. |
|
After
But I'm not finding candlepin-selinux anywhere in Koji (not even for el7, apparently?). @ehelms are we waiting for that to be built or am I missing something? |
|
Use the Koji repository for now similar to pulpcore: http://koji.katello.org/releases/yum/katello-nightly/candlepin/el8/x86_64/ |
|
After my latest changes, the module applies with no errors: [ Idempotence is still failing due to the same relabeling seen on el7 (my other open PR would resolve that, but needs a tweak) ] However Candlepin itself is not working: Checking logs for more details: |
ekohl
reviewed
Mar 23, 2020
| major = fact_on(host, 'os.release.major') | ||
|
|
||
| if major == '8' | ||
| on host, 'dnf -y module enable pki-core' |
There was a problem hiding this comment.
What's in the pki-core module? Does that mean we need that module enabled on every candlepin install?
There was a problem hiding this comment.
[root@centos8-64-1 ~]# dnf module info pki-core
Last metadata expiration check: 0:04:02 ago on Mon 23 Mar 2020 05:04:27 PM UTC.
Name : pki-core
Stream : 10.6 [e] [a]
Version : 8010020191120041437
Context : 8ba0ffbe
Repo : AppStream
Summary : PKI Core module for PKI 10.6 or later
Description : A module for PKI Core packages for PKI version 10.6 or later.
Artifacts : jss-0:4.6.0-5.module_el8.1.0+238+005506d1.src
: jss-0:4.6.0-5.module_el8.1.0+238+005506d1.x86_64
: jss-debuginfo-0:4.6.0-5.module_el8.1.0+238+005506d1.x86_64
: jss-debugsource-0:4.6.0-5.module_el8.1.0+238+005506d1.x86_64
: jss-javadoc-0:4.6.0-5.module_el8.1.0+238+005506d1.x86_64
: ldapjdk-0:4.21.0-1.module_el8.1.0+238+005506d1.noarch
: ldapjdk-0:4.21.0-1.module_el8.1.0+238+005506d1.src
: ldapjdk-javadoc-0:4.21.0-1.module_el8.1.0+238+005506d1.noarch
: pki-base-0:10.7.3-1.module_el8.1.0+238+005506d1.noarch
: pki-base-java-0:10.7.3-1.module_el8.1.0+238+005506d1.noarch
: pki-ca-0:10.7.3-1.module_el8.1.0+238+005506d1.noarch
: pki-core-0:10.7.3-1.module_el8.1.0+238+005506d1.src
: pki-kra-0:10.7.3-1.module_el8.1.0+238+005506d1.noarch
: pki-server-0:10.7.3-1.module_el8.1.0+238+005506d1.noarch
: pki-symkey-0:10.7.3-1.module_el8.1.0+238+005506d1.x86_64
: pki-symkey-debuginfo-0:10.7.3-1.module_el8.1.0+238+005506d1.x86_64
: pki-tools-0:10.7.3-1.module_el8.1.0+238+005506d1.x86_64
: pki-tools-debuginfo-0:10.7.3-1.module_el8.1.0+238+005506d1.x86_64
: python3-pki-0:10.7.3-1.module_el8.1.0+238+005506d1.noarch
: tomcatjss-0:7.4.1-1.module_el8.1.0+238+005506d1.noarch
: tomcatjss-0:7.4.1-1.module_el8.1.0+238+005506d1.src
Hint: [d]efault, [e]nabled, [x]disabled, [i]nstalled, [a]ctive]
The important part above is the tomcatjss -- without it, we get:
An error occurred in a `before(:suite)` hook.
Failure/Error: on host, 'yum -y install candlepin-selinux'
Beaker::Host::CommandFailure:
Host 'centos8-64-1' exited with 1 running:
yum -y install candlepin-selinux
Last 10 lines of output were:
Repository 'candlepin' is missing name in configuration, using id.
candlepin 12 kB/s | 13 kB 00:01
Extra Packages for Enterprise Linux Modular 8 - 50 kB/s | 117 kB 00:02
Extra Packages for Enterprise Linux 8 - x86_64 1.8 MB/s | 6.1 MB 00:03
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
Error:
Problem: package candlepin-selinux-3.1.3-1.el8.noarch requires candlepin = 3.1.3-1.el8, but none of the providers can be installed
- package candlepin-3.1.3-1.el8.noarch requires tomcatjss >= 7.2.1-7.1, but none of the providers can be installed
- conflicting requests
- package tomcatjss-7.4.1-1.module_el8.1.0+238+005506d1.noarch is excluded
Thinking about it, I am not sure if the pki-core module can be installed as an RPM dependency... do you think it makes better sense to tackle it here rather than in packaging, @ekohl ?
There was a problem hiding this comment.
I'm not familiar enough with modularity to say, but this should at least be on the list of things to be aware of.
ekohl
reviewed
Mar 23, 2020
| @@ -22,14 +22,32 @@ | |||
| c.before :suite do | |||
| # Install module and dependencies | |||
| hosts.each do |host| | |||
| if fact_on(host, 'osfamily') == 'RedHat' | |||
| if fact_on(host, 'os.family') == 'RedHat' | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Will do shortly, thanks
|
Can we tie this to the Redmine issue for puppet-candlepin? I think based on the errors, we should just drop https://github.com/theforeman/puppet-candlepin/blob/master/manifests/database/postgresql.pp#L41-L42 You are also going to hit certificate permission errors if I recall from past testing. The example (https://github.com/theforeman/puppet-candlepin/blob/master/examples/basic_candlepin.pp) used in testing deploys certificate with |
|
Here is a diff of the changes I had to make to get the certs working with tomcat correctly: |
wbclark
force-pushed
the
el8
branch
2 times, most recently
from
d4144bd
to
b0ff06c
Compare
wbclark
changed the title
|
Try dropping these two lines https://github.com/theforeman/puppet-candlepin/blob/master/manifests/database/postgresql.pp#L41-L42 |
wbclark
changed the title
wbclark
force-pushed
the
el8
branch
2 times, most recently
from
98e8f62
to
74f0ee5
Compare
ehelms
reviewed
Mar 27, 2020
wbclark
force-pushed
the
el8
branch
2 times, most recently
from
b396e94
to
01fb9cb
Compare
ehelms
approved these changes
Mar 30, 2020
ekohl
approved these changes
Apr 2, 2020
|
General note that I normally write something like |
|
@ekohl I've updated metadata.json and commit message. Thanks! |
wbclark
changed the title
ekohl
approved these changes
Apr 3, 2020
|
Now that the unit tests run with EL8, the repo assertion fails. Other than that 👍 |
wbclark
commented
Apr 3, 2020
ekohl
reviewed
Apr 4, 2020
|
I've added a change, this should be squashed on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.