Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #31497 - set default-consumer-window-size for jobs queue #170

Merged
merged 1 commit into from Dec 15, 2020

Conversation

jturel
Copy link
Contributor

@jturel jturel commented Dec 11, 2020

Keeping in sync with Candlepin's broker.xml => candlepin/candlepin#2859

Copy link
Contributor

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's wrong with the tests on EL8 but it seems unrelated since I can't reproduce it when running them locally:

After running it a 2nd time (to work around an selinux/idempotence issue that doesn't exist in the docker containers we use for CI):

centos8-64-1 executed in 0.34 seconds
is expected to be listening
Command "curl -k -s -o /dev/null -w '%{http_code}' https://localhost:8443/candlepin/status"
stdout

centos8-64-1 11:34:38$ /bin/sh -c curl\ -k\ -s\ -o\ /dev/null\ -w\ '%{http_code}'\ https://localhost:8443/candlepin/status
200
centos8-64-1 executed in 14.20 seconds
is expected to eq "200"

@ekohl
Copy link
Member

ekohl commented Dec 15, 2020

Given what @wbclark said and that we see the same failure also in other tests, I'm going to merge this now.

@ekohl ekohl merged commit adc6754 into theforeman:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants