Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #31607 - Increase Artemis disk usage limit #172

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

jturel
Copy link
Contributor

@jturel jturel commented Jan 11, 2021

Keeping in sync with Candlepin's broker.xml => candlepin/candlepin#2875

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this should be a parameter but I can't really estimate how often you would want to change it. Personally I think that you really should just try to use all the space and require disk space monitoring by using a proper monitoring solution. This just stops sending messages and quietly doesn't do anything anymore. That's IMHO bad so 99% is probably fine for most cases.

@jturel
Copy link
Contributor Author

jturel commented Jan 11, 2021

I was wondering if this should be a parameter but I can't really estimate how often you would want to change it. Personally I think that you really should just try to use all the space and require disk space monitoring by using a proper monitoring solution. This just stops sending messages and quietly doesn't do anything anymore. That's IMHO bad so 99% is probably fine for most cases.

Agree. We are basically hamstrung by the capability Artemis gives us today. We should have a better way in the future: https://issues.apache.org/jira/browse/ARTEMIS-3057

@ekohl
Copy link
Member

ekohl commented Jan 11, 2021

Sounds good to me and that JIRA issue does sound good to me.

@ekohl ekohl merged commit 28bb219 into theforeman:master Jan 11, 2021
@jturel jturel deleted the artemis_usage_limit branch January 11, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants