Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian grub2: update efi file name to align with symlink name #217

Merged
merged 1 commit into from Mar 28, 2023

Conversation

jklare
Copy link
Contributor

@jklare jklare commented Mar 24, 2023

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some research (since I'm not well known in this area) links to https://unix.stackexchange.com/questions/565615/efi-boot-bootx64-efi-vs-efi-ubuntu-grubx64-efi-vs-boot-grub-x86-64-efi-gru. That tells me:

This is the only bootloader pathname that the UEFI firmware on 64-bit X86 systems will look for without any pre-existing NVRAM boot settings, so this is what you want to use on removable media.

So that's probably why this default is here. Since Debian 10 grub-efi-amd64-bin contains /usr/lib/grub/x86_64-efi/monolithic/grubx64.efi and looks like what we actually want. So I'm wondering if the netboot class should link/copy /usr/lib/grub/x86_64-efi/monolithic/grubx64.efi instead of calling grub-mkimage.

I didn't check Ubuntu's history, but at least Ubuntu 20.04 has the same file structure.

manifests/params.pp Outdated Show resolved Hide resolved
manifests/params.pp Outdated Show resolved Hide resolved
* the files with the path grub2/bootx64.efi do not exist on a ubuntu
  20.04 installation with foreman 3.6.0
* this change updates the path used to grub2/grubx64.efi and
  grub2/grubia32.efi respectively

Signed-off-by: Jan Klare <jan.klare@bisdn.de>
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@jklare
Copy link
Contributor Author

jklare commented Mar 27, 2023

Thanks @ekohl for all the research and help, i updated the commits accordingly.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit e3ef40e into theforeman:master Mar 28, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants