Add AlmaLinux 8 & 9 support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jun 6, 2024
@ekohl i don't understand this one as well? would you mind expanding it more? |
|
If you look for EPEL in he module you can find: puppet-dhcp/spec/setup_acceptance_node.pp Lines 1 to 6 in 545894d I'd recommend checking for the Red Hat family and excluding the Fedora OS instead. |
ekohl
requested changes
Jul 16, 2024
Added AlmaLinux 8 and 9 to the supported operating systems in metadata.json. These changes ensure that we start testing with AlmaLinux 8 and 9 instead of CentOS 8 Stream. This update is part of our transition to better support AlmaLinux in our Puppet modules. See, for details: theforeman/foreman-infra#2087
ehelms
approved these changes
Jul 16, 2024
ekohl
reviewed
Jul 16, 2024
| if $facts['os']['name'] == 'CentOS' { | ||
| package { 'epel-release': | ||
| if $facts['os']['family'] == 'RedHat' and $facts['os']['name'] != 'Fedora' { | ||
| package { 'epel-release': |
There was a problem hiding this comment.
Please be careful with indenting. I'm surprised CI didn't flag this
Suggested change
| package { 'epel-release': | |
| package { 'epel-release': |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AlmaLinux 8 and 9 to the supported operating systems in metadata.json.
These changes ensure that we start testing with AlmaLinux 8 and 9 instead of CentOS 8 Stream. This update is part of our transition to better support AlmaLinux in our Puppet modules.
See, for details: theforeman/foreman-infra#2087