Drop /pulp2 and /streamer from no_proxy_uris #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be labeled |
Yes. We're doing a major release anyway so it's just a clearer signal to users reading the changelog.
Looks like GH doesn't recognize the commit is redundant. Needs a (trivial) rebase now :( |
These were only needed with Pulp2 which we don't support anymore.
ekohl
approved these changes
Aug 26, 2022
|
Rebased! Yes, GH doesn't recognize such trivial rebases, but better than getting a vim window again ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1078, because I am lazy and don't want to rebase again.