New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #36319 - Add fog_proxmox plugin support #1115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this commit doesn't add it to the installer, but it does open the path. So I'd make this commit Add fog_proxmox plugin support
.
You could also use a Redmine issue (https://projects.theforeman.org/projects/puppet-foreman/issues/new) and then make this one Refs #NNN - Add fog_proxmox plugin support
and the one in foreman-installer Fixes #NNN - ...
. That makes it show up in the changelogs and easier if we decide to cherry pick it to a stable release.
Thanks @ekohl I have opened an issue and referenced it: https://projects.theforeman.org/issues/36319 |
Puppet 6 failures are unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this Refs #36319
? The PR to foreman-installer should be Fixes #36319
and this is just a preparation.
Yes, reworded my commit message. |
Adding the plug-in to foreman-installer: * theforeman/foreman-installer#845 * theforeman/puppet-foreman#1115 * https://projects.theforeman.org/issues/36319
Adding the plug-in to foreman-installer: * theforeman/foreman-installer#845 * theforeman/puppet-foreman#1115 * https://projects.theforeman.org/issues/36319
Adding the plug-in to foreman-installer: * theforeman/foreman-installer#845 * theforeman/puppet-foreman#1115 * https://projects.theforeman.org/issues/36319 (cherry picked from commit d4b1e31)
In foreman-documentation, we're in the process of adding documentation on how to use Proxmox as compute resource provider in Foreman. See theforeman/foreman-documentation#2142 (comment)