Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #36319 - Add fog_proxmox plugin support #1115

Merged
merged 1 commit into from Apr 25, 2023

Conversation

maximiliankolb
Copy link
Contributor

In foreman-documentation, we're in the process of adding documentation on how to use Proxmox as compute resource provider in Foreman. See theforeman/foreman-documentation#2142 (comment)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this commit doesn't add it to the installer, but it does open the path. So I'd make this commit Add fog_proxmox plugin support.

You could also use a Redmine issue (https://projects.theforeman.org/projects/puppet-foreman/issues/new) and then make this one Refs #NNN - Add fog_proxmox plugin support and the one in foreman-installer Fixes #NNN - .... That makes it show up in the changelogs and easier if we decide to cherry pick it to a stable release.

manifests/plugin/proxmox.pp Outdated Show resolved Hide resolved
@maximiliankolb
Copy link
Contributor Author

Thanks @ekohl

I have opened an issue and referenced it: https://projects.theforeman.org/issues/36319

spec/classes/plugin/proxmox_spec.rb Outdated Show resolved Hide resolved
@ekohl ekohl changed the title Add Proxmox to foreman-installer Fixes #36319 - Add fog_proxmox plugin support Apr 19, 2023
@maximiliankolb maximiliankolb marked this pull request as ready for review April 19, 2023 12:44
@ekohl
Copy link
Member

ekohl commented Apr 25, 2023

Puppet 6 failures are unrelated.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this Refs #36319? The PR to foreman-installer should be Fixes #36319 and this is just a preparation.

@maximiliankolb maximiliankolb changed the title Fixes #36319 - Add fog_proxmox plugin support Refs #36319 - Add fog_proxmox plugin support Apr 25, 2023
@maximiliankolb
Copy link
Contributor Author

Can you make this Refs #36319? The PR to foreman-installer should be Fixes #36319 and this is just a preparation.

Yes, reworded my commit message.

@ekohl ekohl merged commit 51c8107 into theforeman:master Apr 25, 2023
7 of 10 checks passed
@maximiliankolb maximiliankolb deleted the proxmox branch April 25, 2023 14:38
maximiliankolb added a commit to ATIX-AG/foreman-documentation that referenced this pull request Jun 19, 2023
maximiliankolb added a commit to theforeman/foreman-documentation that referenced this pull request Jun 19, 2023
maximiliankolb added a commit to theforeman/foreman-documentation that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants