refs #3752 - run db:seed after DB migration #127
Conversation
|
I'm starting to think about a |
|
@ekohl how's that? |
| @@ -0,0 +1,10 @@ | |||
| # Run a Foreman rake task when notified | |||
| define foreman::rake() { | |||
| exec { "rake-${title}": | |||
There was a problem hiding this comment.
Maybe name this foreman-rake-${title}?
|
@domcleal Minor comments inline, but I like it. |
|
Thanks for the feedback, PR updated. |
|
👍 looks great. |
|
Please hold on merging until the core PR hits and is merged. |
|
It should still work on released versions so what is the problem with nightly? |
|
@ekohl just in case my PR's rejected :) |
|
@domcleal fair enough, but then I still like |
| # Run a Foreman rake task when notified | ||
| define foreman::rake() { | ||
| exec { "foreman-rake-${title}": | ||
| command => "/usr/sbin/foreman-rake ${title}", |
There was a problem hiding this comment.
Is foreman-rake in sbin on Debian. I think @GregSutcliffe mentioned something about hate of "sbins" :-D
There was a problem hiding this comment.
It is:
debian/precise/foreman/foreman.install
5:script/foreman-debug usr/sbin
6:script/foreman-rake usr/sbin
There was a problem hiding this comment.
I may not like them, but that's because on Arch, everything is in /usr/bin :P - on Debian, I still have to use their guidelines...
|
👍 as and when core is updated. also 👍 to keeping foreman::rake if it isn't :) |
|
Core PR's merged, this is now needed for nightlies, would somebody mind merging please? |
|
Merged in 9344250. |
Using foreman-rake means 1.3+, but I think we said that we'd support current stable + the development version. Running db:seed on 1.3 will be fine as either the seed file doesn't exist (no error) or it contains next to nothing.