Use apache mod classes #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pl-apache PR has been merged and rebased. Do we want to wait for a pl-apache release though? |
domcleal
suggested changes
May 19, 2017
manifests/config/passenger.pp
Outdated
| @@ -95,6 +95,13 @@ | |||
| include ::apache::mod::headers | |||
| include ::apache::mod::passenger | |||
|
|
|||
| if $::foreman::ipa_authentication { | |||
There was a problem hiding this comment.
This should be added to the local class parameters list so it can be set in foreman::config::passenger tests.
domcleal
suggested changes
May 19, 2017
| @@ -314,6 +319,41 @@ | |||
| should contain_apache__vhost('foreman-ssl').with_passenger_pre_start("https://#{facts[:fqdn]}:8443") | |||
| end | |||
| end | |||
|
|
|||
| describe 'with different ports set' do | |||
There was a problem hiding this comment.
with ipa_authentication => true ?
domcleal
approved these changes
May 19, 2017
Requires puppetlabs-apache 7301123aa51afe696f129988482889f61aa4f0d0 which is shipped since 2.0.0 so we bump the required version. [1] puppetlabs/puppetlabs-apache@7301123
|
Rebased now that puppetlabs-apache 2.0.0 is out. |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires puppetlabs/puppetlabs-apache#1588