Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #22196 - use ssl chain for hammer if available #615

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

stbenjam
Copy link
Member

@theforeman-bot
Copy link
Member

@stbenjam, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

@stbenjam
Copy link
Member Author

stbenjam commented Jan 10, 2018

Actually chain has to have a value so the pick will never fall through to just the CA. I updated it to only use the chain for hammer.

I wonder if that's actually a bug hiding there, if a user in Foreman tries to use their own custom certs and only specifies a CA File but chain defaults to the Puppet certs. That'd not happen in Katello though, but I don't know much about how Foreman-only users tend to set this up.

@stbenjam
Copy link
Member Author

@ekohl I made a small change, could you take a quick look again?

@ekohl ekohl merged commit a44162f into theforeman:master Jan 15, 2018
@ekohl
Copy link
Member

ekohl commented Jan 15, 2018

Thanks!

@stbenjam stbenjam deleted the 22196 branch January 15, 2018 13:32
@ekohl ekohl added the Bug label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants