Refactor repo handling #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need to split out a few more things, work on tests and reorder a bit. Then I'll need to verify if there are more version specific workarounds we can get rid of. Also thinking about removing the explicit failures about an unsupported OS and setting values to undef so people can override where needed. |
ekohl
force-pushed
the
refactor-repo-handling
branch
from
852f3d4
to
95e6aa4
Compare
ekohl
force-pushed
the
refactor-repo-handling
branch
from
95e6aa4
to
151bbae
Compare
ehelms
approved these changes
Aug 15, 2018
|
tests fail. |
ekohl
force-pushed
the
refactor-repo-handling
branch
3 times, most recently
from
34803fb
to
d6df712
Compare
|
this needs a rebase :) |
ekohl
force-pushed
the
refactor-repo-handling
branch
from
d6df712
to
981daf4
Compare
* Drop use of the 'stable' repository * Disallow releases/ as part of the repository * Add foreman-rails repository * Stop including foreman::params * Remove anchor pattern * Move to https
ekohl
force-pushed
the
refactor-repo-handling
branch
from
981daf4
to
bc46573
Compare
|
Updated to fix a bug in the yum handling. Debian nightlies are still broken so can't promise we don't have regressions there. |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need #659 for the acceptance tests to pass.
Note that the foreman-rails repository assumes Foreman 1.17+ so that'll become the new minimum version. I'm going to continue with removing some compatibility with older versions in follow up PRs.