Fixes #25787 - Make login and taxonomy settings optional #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekohl - i hope this is what you meant in #690 (comment) ? |
ekohl
requested changes
Jan 10, 2019
This was referenced Jan 10, 2019
ekohl
approved these changes
Jan 10, 2019
manifests/init.pp
Outdated
| # $organizations_enabled:: Enable organizations? (Unused since 1.21) | ||
| # | ||
| # $authentication:: Enable user authentication. (Unused since 1.21) | ||
| # Initial credentials are set using admin_username and admin_password. |
There was a problem hiding this comment.
Looks like there was also an oversight here: these are now prefixed with initial_.
ekohl
approved these changes
Jan 11, 2019
|
There's a merge conflict now :( |
|
@ekohl thanks, rebased on latest master now. |
mmoll
reviewed
Jan 13, 2019
|
@tbrisker one tiny thing :) |
ekohl
approved these changes
Jan 13, 2019
|
merged, thanks @tbrisker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.