Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the defaults switched #712

Merged
merged 1 commit into from Jan 18, 2019
Merged

Clarify the defaults switched #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -51,11 +51,22 @@ previous stable release.

### Foreman version compatibility notes

For Foreman 1.16 or older, please use the 9.x release series of this module.
The parameters `locations_enabled`, `organizations_enabled` and `authentication`
will only have any affect on Foreman 1.20 or older, in newer versions these
settings have been removed.

**Warning** Users configuring Foreman 1.20 and earlier will need to pay
particular attention. Some defaults have been flipped, including all user
authentication.

| Setting | module 11.x with 1.20 | module 10.x with 1.20 |
|----------------------------|-----------------------|-----------------------|
| `authentication` (`login`) | false | true |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in 1.20 and earlier login still defaults to true if missing (https://github.com/theforeman/foreman/blob/1.20-stable/config/settings.rb#L11 and https://github.com/theforeman/foreman/blob/1.19-stable/config/settings.rb#L10)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not in 1.18 which I was still using...

https://github.com/theforeman/foreman/blob/1.18-stable/config/settings.rb#L11

I was prepping for upgrading to 1.19 by first updating Puppet modules and refactoring my profiles etc.

| `locations_enabled` | true | false |
| `organizations_enabled ` | true | false |

For Foreman 1.16 or older, please use the 9.x release series of this module.

## Types and providers

`foreman_config_entry` can be used to manage settings in Foreman's database, as
Expand Down