Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for foreman_inventory_upload plugin #749

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Add support for foreman_inventory_upload plugin #749

merged 2 commits into from
Aug 21, 2019

Conversation

ShimShtein
Copy link
Member

No description provided.

ekohl
ekohl requested changes Aug 20, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin already assumes the foreman_ prefix. Can you rename it to inventory_upload?

@ShimShtein
Copy link
Member Author

@ekohl, renamed

@ShimShtein
Copy link
Member Author

@ekohl thanks for the correction. Anything else?

ekohl
ekohl approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, was waiting for the tests to finish.

@ekohl ekohl merged commit dfc8d89 into theforeman:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShimShtein @ekohl @theforeman-bot