Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supervisory_authority plugin #754

Merged
merged 4 commits into from
Aug 29, 2019
Merged

Add supervisory_authority plugin #754

merged 4 commits into from
Aug 29, 2019

Conversation

laugmanuel
Copy link
Member

templates/foreman_supervisory_authority.yaml.erb Outdated Show resolved Hide resolved
#
# This class installs the supervisory_authority plugin and configuration file
#
# === Parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to split this up into Parameters and Advanced Parameters? If not, I prefer the puppet-strings syntax since it's the officially supported one. However, RDoc has the feature of parameter groups which we do use in our installer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the "Advanced Parameters" section with all parameters which are optional.
The doc-block was taken from another plugin (memcache) to be consistent with whats already there.
I think we should rework the RDoc in all the Puppet files at once to not have different styles of documenting stuff.
What do you think?

@laugmanuel
Copy link
Member Author

I did change the default values of some optional/advanced parameters to correspond with the default values of the elastic documentation.

@ekohl ekohl merged commit 82c5366 into theforeman:master Aug 29, 2019
@ekohl
Copy link
Member

ekohl commented Aug 29, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants