fixes #2628 - install foreman-selinux when SELinux is enabled #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Untested but looks fine. Travis think you broke the world though ;) |
|
Tests have been broken for a while :) |
| @@ -29,4 +29,11 @@ | |||
| ensure => present, | |||
| require => $repo, | |||
| } | |||
|
|
|||
| if $foreman::selinux or ($::selinux and $foreman::selinux != false) { | |||
There was a problem hiding this comment.
I think $::selinux is a string since it comes from facter. You may want to use str2bool.
There was a problem hiding this comment.
Great catch, thanks.
|
Updated with str2bool, added explicit stdlib dep. |
|
Now with tests! |
|
👍 yay for tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm willing to hold off until #69's merged, assuming we do it pre-1.2 and can add tests for this behaviour.