Remove outdated providers docs #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 5, 2021
README.md
Outdated
Comment on lines
82
to
84
| seen in _Administer > Settings_. | ||
|
|
||
| * `cli` provider uses `foreman-rake` to change settings (default) | ||
|
|
||
| `foreman_hostgroup` can create and manage host group in Foreman's database. | ||
| Providers: | ||
|
|
||
| * `rest_v2` provider uses API v2 with apipie-bindings and OAuth (default) | ||
| * `cli` provider uses `foreman-rake` to change settings |
There was a problem hiding this comment.
How about making it a nice flowing paragraph now that it's no longer a list?
Suggested change
| seen in _Administer > Settings_. | |
| * `cli` provider uses `foreman-rake` to change settings (default) | |
| `foreman_hostgroup` can create and manage host group in Foreman's database. | |
| Providers: | |
| * `rest_v2` provider uses API v2 with apipie-bindings and OAuth (default) | |
| * `cli` provider uses `foreman-rake` to change settings | |
| seen in _Administer > Settings_. The `cli` provider uses `foreman-rake` to change settings. |
Probably the same for foreman_smartproxy
There was a problem hiding this comment.
Updated. (I thought I'd pushed last night, but there'd been some network error and it hadn't made it out)
ekohl
reviewed
Oct 6, 2021
README.md
Outdated
|
|
||
| * `rest_v3` provider uses API v2 with Ruby HTTP library, OAuth and JSON (default) | ||
| * `rest_v2` provider uses API v2 with apipie-bindings and OAuth | ||
| Foreman's database. The `rest_v3` provider uses API v2 with Ruby HTTP library, OAuth and JSON |
There was a problem hiding this comment.
Clearly I wasn't paying attention yesterday. By now we've dropped API v1 so should we simplify it to
Suggested change
| Foreman's database. The `rest_v3` provider uses API v2 with Ruby HTTP library, OAuth and JSON | |
| Foreman's database. The `rest_v3` provider uses the API with Ruby's HTTP library, OAuth and JSON. |
README.md
Outdated
| Providers: | ||
|
|
||
| * `rest_v2` provider uses API v2 with apipie-bindings and OAuth (default) | ||
| seen in _Administer > Settings_. The `cli` provider uses `foreman-rake` to change settings |
There was a problem hiding this comment.
Suggested change
| seen in _Administer > Settings_. The `cli` provider uses `foreman-rake` to change settings | |
| seen in _Administer > Settings_. The `cli` provider uses `foreman-rake` to change settings. |
apipie-based providers (and the `foreman_hostgroup` type completely) were removed in theforeman#663 This updates the README to reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apipie-based providers (and the
foreman_hostgrouptype completely)were removed in #663
This updates the README to reflect this.