Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::tftp module is not optional #270

Closed
pkranenburg opened this issue Aug 5, 2016 · 3 comments
Closed

::tftp module is not optional #270

pkranenburg opened this issue Aug 5, 2016 · 3 comments

Comments

@pkranenburg
Copy link

pkranenburg commented Aug 5, 2016

Despite setting parameter 'tftp_manage' to false, the module still insists on including ::tftp::params.
This should not happen and can presumably be fixed easily by these modifications:

In params.pp: don't include ::tftp::params
In tftp:pp: lazily evaluate variable 'tftp_root':
if ($foreman_proxy::tftp_root == undef) {
initialize from tftp::params
} else {
use main parameter value
}

@pkranenburg
Copy link
Author

Ok, this issue appears to have been resolved in the current version on github.

I'll retract this issue (#270) and wait for the release to appear.

@ekohl
Copy link
Member

ekohl commented Aug 5, 2016

@domcleal or @mmoll should we do a release?

@mmoll
Copy link
Contributor

mmoll commented Aug 5, 2016

maybe after #267 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants