Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding log_level parameter - fixes #8939 #137

Conversation

gpetras
Copy link

@gpetras gpetras commented Jan 13, 2015

No description provided.

@mmoll
Copy link
Contributor

mmoll commented Jan 14, 2015

Please add documentation for the parameter in the header of init.pp, kafo/foreman-installer needs this.
Looking fine otherwise 👍

@mmoll mmoll changed the title adding log_level parameter - fixes #8969 adding log_level parameter - fixes #8939 Jan 14, 2015
@mmoll
Copy link
Contributor

mmoll commented Jan 14, 2015

also, the commit message needs to reference the correct issue ;)

@ekohl
Copy link
Member

ekohl commented Jan 14, 2015

What @mmoll said.

@gpetras
Copy link
Author

gpetras commented Jan 14, 2015

lol, thanks. I'll get that fixed.

@gpetras gpetras force-pushed the feature/8939-add-log_level-parameter branch from 2393955 to 49e5896 Compare January 14, 2015 15:50
@gpetras gpetras force-pushed the feature/8939-add-log_level-parameter branch from 49e5896 to 6196b45 Compare January 14, 2015 15:51
@@ -24,6 +24,8 @@
#
# $log:: Foreman proxy log file
#
# $log_level:: Foreman proxy log level, ie INFO,i DEBUG, FATAL, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, will squash a fix into the merge

@mmoll
Copy link
Contributor

mmoll commented Jan 14, 2015

merged as 10ee4ce, thanks @gpetras 🎉

@mmoll mmoll closed this Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants