Add smart_proxy_chef plugin support #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| foreman_proxy::plugin {'chef': | ||
| } -> | ||
| file {'/etc/foreman-proxy/settings.d/chef.yml': |
There was a problem hiding this comment.
Please use foreman_proxy::settings_file.
|
Could you write a (minimal) test case for it? |
| class foreman_proxy::plugin::chef::params { | ||
| $enabled = true | ||
| $group = undef | ||
| $server_url = "https://${fqdn}" |
ares
force-pushed
the
master
branch
2 times, most recently
from
a41b8e4
to
ed34e29
Compare
|
@ekohl thanks for review, I fixed it and added test to check basic functionality |
| $ssl_verify = $::foreman_proxy::plugin::chef::params::ssl_verify, | ||
| $ssl_pem_file = $::foreman_proxy::plugin::chef::params::ssl_pem_file, | ||
| ) inherits foreman_proxy::plugin::chef::params { | ||
| $group_real = pick($group, $::foreman_proxy::user) |
There was a problem hiding this comment.
You can leave this out (and the validate_string) since the settings file defaults to the correct value and you already have undef in params.pp.
|
Minor nitpick, otherwise ok. |
ehelms
pushed a commit
to ehelms/puppet-foreman_proxy
that referenced
this pull request
Aug 25, 2017
Add foreman-tasks to PR scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.