Fixes #30121 - Generate SSH keys in PEM format #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On EL8 the keys get generated in RFC4716 which doesn't play well with the version of net-ssh we currently ship.
wbclark
approved these changes
Jun 15, 2020
|
Could we have updated the net-ssh version or will we run into https://projects.theforeman.org/issues/30162 then? |
|
Even the latest and greatest version of net-ssh considers all private keys beginning with |
|
But can't we ship the gems to support ed25519 as well or is that still a problem? That's probably more a packaging issue, but IMHO a good feature to support. Users might generate their own ed25519 keys and run into problems. |
|
We could and we should, but that wouldn't change anything on the fact that net-ssh would still incorrectly detect the key type. |
|
Ok, that sounds like a known issue we should document for REX users on EL8. |
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 6, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 6, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 7, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 7, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 20, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 20, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 24, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 25, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 28, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 28, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
May 28, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Jun 7, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Jun 7, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Jun 8, 2021
jhoblitt
added a commit
to lsst-it/lsst-control
that referenced
this pull request
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On EL8 the keys get generated in RFC4716 format which doesn't play well with the version of net-ssh we currently ship.