Drop ansible-runner repository management

[ehelms]

The ansible-runner package is now delivered via the Foreman plugins repository.

Requires that ansible-runner be in the plugins repository (theforeman/foreman-packaging#8434)

[evgeni]

Should we clean up the old repo definition?

[evgeni]

And speaking if cleanup, I think f-maintain also has some (wrong) special handling that should be removed.

[ehelms]

And speaking if cleanup, I think f-maintain also has some (wrong) special handling that should be removed.

I grepped around and couldn't find any. Anything in particular you are thinking it did?

[evgeni]

And speaking if cleanup, I think f-maintain also has some (wrong) special handling that should be removed.

I grepped around and couldn't find any. Anything in particular you are thinking it did?

https://github.com/theforeman/foreman_maintain/blob/5f9bf72d5d09f6277d5ee581553f9a7273d8223f/definitions/checks/non_rh_packages.rb#L31

[ehelms]

https://github.com/theforeman/foreman_maintain/blob/5f9bf72d5d09f6277d5ee581553f9a7273d8223f/definitions/checks/non_rh_packages.rb#L31

I think we still want that? As we deliver ansible-runner in upstream and downstream does as well?

[evgeni]

No, that check is to allow upstream runner packages in downstream, which is wrong.

[ehelms]

No, that check is to allow upstream runner packages in downstream, which is wrong.

I still don't think I understand. The only thing we are changing is the version of ansible-runner being packaged up. Why would that affect this logic?

[ekohl]

The code reads well, but there is the part of compatibility. This is breaking, unless we backport the packaging changes to 3.4 (which I'd actually like to see). See https://github.com/theforeman/puppet-foreman_proxy#compatibility as well.

Looks like for now we don't have a breaking change, though #630 will be. If we do go for the breaking change route, I'd like to get a release out with the current changes first.

[ekohl]

I think this breaks lint

Suggested change

[ekohl]

I still don't think I understand. The only thing we are changing is the version of ansible-runner being packaged up. Why would that affect this logic?

In foreman-maintain it verifies the vendor on packages, but allows an exception for ansible-runner. That exception becomes redundant once it's packaged by RH and can be dropped.

[ehelms]

In foreman-maintain it verifies the vendor on packages, but allows an exception for ansible-runner. That exception becomes redundant once it's packaged by RH and can be dropped.

This is what confuses me - it's already packaged by RH.

[ekohl]

The exclusion doesn't break anything, it just makes the check weaker than it needs to. So even without this, it can be dropped.

[evgeni]

In foreman-maintain it verifies the vendor on packages, but allows an exception for ansible-runner. That exception becomes redundant once it's packaged by RH and can be dropped.

This is what confuses me - it's already packaged by RH.

And that's the wrong part. It allows the non RH (= upstream) package on an RH installs (because someone sometimes forgot to set manage_repo = false)

[ehelms]

In foreman-maintain it verifies the vendor on packages, but allows an exception for ansible-runner. That exception becomes redundant once it's packaged by RH and can be dropped.

This is what confuses me - it's already packaged by RH.

And that's the wrong part. It allows the non RH (= upstream) package on an RH installs (because someone sometimes forgot to set manage_repo = false)

Done over here -- theforeman/foreman_maintain#644

[ehelms]

Looks like for now we don't have a breaking change, though #630 will be. If we do go for the breaking change route, I'd like to get a release out with the current changes first.

We already have a merged breaking change (#776). There are two non-breaking commits that if we wanted we'd have to do a branch and release with those:

• 41bbfba
• 7ea5ed0

Given that would require a branch, I think a release is a separate question from whether this can go in the code base now.

I have included an update to the README.

[ekohl]

Small notes on the readme bit, otherwise 👍